#318: add a function to get information of problems #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fukatani
reviewed
Feb 27, 2019
|
|
||
| def test_get_score(self): | ||
| self.assertEqual(AtCoderProblem.from_url('https://atcoder.jp/contests/future-contest-2018-final/tasks/future_contest_2018_final_a').get_score(), 50000000) | ||
| self.assertEqual(AtCoderProblem.from_url('https://atcoder.jp/contests/abc001/tasks/abc001_4').get_score(), None) |
There was a problem hiding this comment.
get_score()がいつNoneを返すのか説明を書いたほうがいいと思いますが、書くべき場所が無いですかねえ。。
There was a problem hiding this comment.
この指摘は正しいです。
#344 で触れられてる check_with はまさにこの None を処理するためにありました。 check_with みたいな機構が必要な場合はどれもドキュメントが必要な場合であるはずなので、check_with は消して get_score は生で定義して docstring を書くという解決がよい気がしてきました。
|
@kmyk わかりました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
先にpropertyだけ置いておいた部分の中身の実装です。問題名とかがURLから直で取れるようになります