Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#318: improve the interface around submission #345

Merged
merged 2 commits into from
Feb 28, 2019
Merged

#318: improve the interface around submission #345

merged 2 commits into from
Feb 28, 2019

Conversation

kmyk
Copy link
Member

@kmyk kmyk commented Feb 28, 2019

提出周りのinterfaceの改善です。特に、 language と language id の区別が分かるようにします。

@kmyk kmyk added this to the v6.0.0 milestone Feb 28, 2019
@kmyk kmyk requested a review from fukatani February 28, 2019 13:38
@fukatani fukatani assigned kmyk and unassigned fukatani Feb 28, 2019
@fukatani
Copy link
Contributor

yapfだけ修正おねがいします。他はLGTMです！

@kmyk
Copy link
Member Author

kmyk commented Feb 28, 2019

修正しました。同じミスが頻繁にあるのでpre-commit hookの設定もしました。

@kmyk kmyk assigned fukatani and unassigned kmyk Feb 28, 2019
@fukatani fukatani merged commit b5af924 into master Feb 28, 2019
@fukatani fukatani deleted the feature/make-language-id-type branch February 28, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fukatani fukatani Awaiting requested review from fukatani

Assignees

@fukatani fukatani

Labels
None yet
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kmyk @fukatani