Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NONE: add docs/introduction.ja.rst #511

Merged
merged 1 commit into from
Sep 13, 2019
Merged

NONE: add docs/introduction.ja.rst #511

merged 1 commit into from
Sep 13, 2019

Conversation

kmyk
Copy link
Member

@kmyk kmyk commented Sep 10, 2019

紹介文章を書きました。
https://kimiyuki.net/blog/2017/01/19/pr-online-judge-tools/ が完全に腐ってるので置き換えをします。

プレビューは https://github.com/kmyk/online-judge-tools/blob/a25b1bcce4e058e67012983d88af1f00025a01b7/docs/introduction.ja.rst にあります。最終的に公開されることになる URL は https://online-judge-tools.readthedocs.io/en/master/introduction.ja.html です。

@kmyk
Copy link
Member Author

kmyk commented Sep 10, 2019

CI が落ちてるのは #512 なので無視してください

--------------

「それが何であるか」を説明するには「何ができるか」を言う必要がありますが、それだけでは十分ではありません。
「何ができないか」についても言うべきです。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kmyk さんらしい文章ですね:smiley:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

Copy link
Contributor

@fukatani fukatani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

丁寧でいい文章だと思います。
一部私がわかってない機能の説明もあり(リアクティブなど、存在は知っていましたが)、有用です。

@fukatani fukatani assigned kmyk and unassigned fukatani Sep 13, 2019
@fukatani
Copy link
Contributor

@kmyk
テストが通らないとマージできないようなので、rebaseしてtestがpassしたらマージしちゃってOKです。

@kmyk kmyk force-pushed the docs/introduction branch from a25b1bc to f5f0f67 Compare September 13, 2019 14:13
@kmyk
Copy link
Member Author

kmyk commented Sep 13, 2019

rebase しました。マージします。

@kmyk kmyk merged commit a845209 into master Sep 13, 2019
@kmyk kmyk deleted the docs/introduction branch September 13, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants