Add English translation of run-ci-on-your-library. #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fukatani
force-pushed
the
issue/530/run-si
branch
from
5979155 to
ee5fde6
Compare
|
Resolve #530 |
kmyk
reviewed
Nov 3, 2019
docs/run-ci-on-your-library.en.rst
Outdated
| =================================================================== | ||
|
|
||
| If you are a competitive programmer, you probably have an in-house library for competition programming for yourself. | ||
| Such libraries are normally tested manually by submissions using the library to existing contest problems and checking the result is AC or not”. |
There was a problem hiding this comment.
Suggested change
| Such libraries are normally tested manually by submissions using the library to existing contest problems and checking the result is AC or not”. | |
| Such libraries are normally tested manually by submissions using the library to existing contest problems and checking the result is AC or not. |
typo ぽい
kmyk
reviewed
Nov 3, 2019
docs/run-ci-on-your-library.en.rst
Outdated
|
|
||
| For example, the following shell script should be written. | ||
| First, create a file like ``test.cpp``. | ||
| In ``test.cpp``, specify the problem in the form of ``#define PROBLEM http://judge.u-aizu.ac.jp/onlinejudge/description.jsp?id=DSL_2_A&lang=``. |
There was a problem hiding this comment.
Suggested change
| In ``test.cpp``, specify the problem in the form of ``#define PROBLEM http://judge.u-aizu.ac.jp/onlinejudge/description.jsp?id=DSL_2_A&lang=``. | |
| In ``test.cpp``, specify the problem in the form of ``#define PROBLEM http://judge.u-aizu.ac.jp/onlinejudge/description.jsp?id=DSL_2_A``. |
lang= だとページが表示されないのでまずい
kmyk
reviewed
Nov 3, 2019
docs/run-ci-on-your-library.en.rst
Outdated
| Since Codeforces doesn't distribute system test cases, and AtCoder distributes it via DropBox, but automated download is difficult. | ||
|
|
||
| This script is only an example, and if you have requests such as "I want to support Python" or "I want to test only the differences", | ||
| please extend each one. |
There was a problem hiding this comment.
Suggested change
| please extend each one. | |
| please extend this script by yourself. |
each one の one は何を指示してるかよく分からない気がする
kmyk
reviewed
Nov 3, 2019
docs/run-ci-on-your-library.en.rst
Outdated
| That' all. | ||
|
|
||
| You can check the CI results on Travis CI pages. (ex.: https://travis-ci.org/kmyk/competitive-programming-library) | ||
| Badge like |badge| can be generated from URL ``https://img.shields.io/travis/USER/REPO/master.svg``. |
There was a problem hiding this comment.
Suggested change
| Badge like |badge| can be generated from URL ``https://img.shields.io/travis/USER/REPO/master.svg``. | |
| The badge like |badge| can be generated from URL ``https://img.shields.io/travis/USER/REPO/master.svg``. |
kmyk
reviewed
Nov 3, 2019
docs/run-ci-on-your-library.en.rst
Outdated
| Continuous Integration | ||
| ---------------------- | ||
|
|
||
| It's not enough just to have a script that automatically tests when you run it. |
There was a problem hiding this comment.
Suggested change
| It's not enough just to have a script that automatically tests when you run it. | |
| It's not enough just to have a script to run tests. |
そうまずくはないと思うが、なんとなく冗長な気がしたので短くしたい。原文から逐語的には遠くなるが、意味的にはこの方が素直な気がする。
|
@fukatani 翻訳お疲れ様です。 |
|
あまり注意深さを翻訳時に発揮できないのですが、少なくとも最初のバージョンはライブラリ開発者がやったほうがよさそうと思うに至りました。それでも機械翻訳そのままよりはクオリティーはあがっているはず。レビューありがとうございます。 |
kmyk
approved these changes
Nov 4, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.