アップデートがなされていない際に表示するメッセージの追加 #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
アップデートがなされていないときに表示するメッセージの追加
メッセージをプログラム内の他のコマンドの表示と合わせる
kmyk
approved these changes
Nov 6, 2020
There was a problem hiding this comment.
LGTM
@granddaifuku 現状の表示より明らかに改善されるのでこのままマージすることもできます。しかし、表示はさらに改善できると思います。これについてレビューコメントを付けたので、修正して push するか、修正しないことを主張してください
onlinejudge_command/main.py
Outdated
Comment on lines
278
to
279
| logger.info('hint: try updating the version of online-judge-tools') | ||
| logger.info('Please run: $ pip3 install -U online-judge-tools online-judge-api-client') |
There was a problem hiding this comment.
(optional) 1行にまとめたいです。
Suggested change
| logger.info('hint: try updating the version of online-judge-tools') | |
| logger.info('Please run: $ pip3 install -U online-judge-tools online-judge-api-client') | |
| logger.info('hint: try updating the version of online-judge-tools: $ pip3 install -U online-judge-tools online-judge-api-client') |
現状ではログ出力は以下のようになると思います。「更新してね」を伝えるためのメッセージが [HINT] の行と [INFO] の行に分かれてしまっていますが、両方を [HINT] の行にまとめた方がユーザにとって分かりやすいはずです。
$ oj d http://x
[WARNING] update available for online-judge-tools: 11.0.0 -> 11.1.0
[INFO] run: $ pip3 install -U online-judge-tools
[INFO] online-judge-tools 11.0.0 (+ online-judge-api-client 10.5.0)
[ERROR] unknown problem: http://x
[ERROR] unknown contest: http://x
[ERROR] The URL "http://x" is not supported
Traceback (most recent call last):
File "/home/user/.local/lib/python3.6/site-packages/onlinejudge_command/main.py", line 251, in main
run_program(parsed, parser=parser)
File "/home/user/.local/lib/python3.6/site-packages/onlinejudge_command/main.py", line 217, in run_program
download(args)
File "/home/user/.local/lib/python3.6/site-packages/onlinejudge_command/subcommand/download.py", line 36, in download
raise requests.exceptions.InvalidURL('The URL "%s" is not supported' % args.url)
requests.exceptions.InvalidURL: The URL "x" is not supported
[HINT] try updating the version of online-judge-tools
[INFO] Please run: $ pip3 install -U online-judge-tools online-judge-api-client
onlinejudge_command/main.py
Outdated
Comment on lines
285
to
286
| logger.info('hint: try updating the version of online-judge-tools') | ||
| logger.info('Please run: $ pip3 install -U online-judge-tools online-judge-api-client') |
|
@kmyk |
|
ありがとう。完璧です |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#836 に対応しました。
具体的には
if not is_updatedの際に"Please run: $ pip3 install -U online-judge-tools online-judge-api-client" を加えて表示するようにしました。
至らないところなどがあればぜひご指摘お願いします。