Support for ephemeral credentials #1033
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, SIP.js uses the provided credentials to authenticate during the entire session. However, if we want to have ephemeral credentials, we need a way to rotate these credentials during the same session to perform reREGISTER operations.
The goal of this pull request is to improve SIP.js in order to provide a way to obtain credentials in a more dynamic way, i.e. allowing to provide a function that will return the appropriate credentials whenever the (re)authentication is required.
ℹ️ This change was already submitted and approved in the PR #941 but it was never released. I believe it was somehow lost when the default development branch was moved from
mastertomain.