Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor models.py #363

Closed
wants to merge 7 commits into from
Closed

Refactor models.py #363

wants to merge 7 commits into from

Conversation

LuxF3rre
Copy link

  • Removed unused imports
  • Formatted with black
  • Extracted tokenizers and model loaders into their own functions
  • Changed model parameter calling to use kwargs, extracted CPU failover and suggested memory allocation into helper functions, minor readability improvements for memory_map allocation.
  • The general logic untouched

@oobabooga
Copy link
Owner

I find that this makes the code significantly more verbose and harder to read.

Model loading with *kwargs has been also handled in #358

@oobabooga oobabooga closed this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants