Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an experimental simple grid layout #248

Closed
wants to merge 1 commit into from

Conversation

lneves12
Copy link

@lneves12 lneves12 commented Nov 5, 2020

Issue: #247

Adds an experimental simple grid layout under an option "--grid". This assumes a grid of 2 columns, should be enough for now.

Let me know what you think about this approach.

Example with even number of cells

Screenshot from 2020-11-05 01-47-18

Example with odd number of cells

Screenshot from 2020-11-05 01-47-03

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.6%) to 91.429% when pulling 3988312 on lneves12:master into b62a2a1 on kimmobrunfeldt:master.

@lneves12
Copy link
Author

lneves12 commented Jul 2, 2021

any feedback about this new experimental layout?

Is there anything else I should add/improve in order to have this approved?

let me know what you think @gustavohenke

Thanks!

@amertak
Copy link

amertak commented Feb 15, 2022

I would love to see this feature released @lneves12

@nicholas-ochoa
Copy link

Any chance of this getting merged? This would be a very useful feature when there are multiple applications running that are in a watch mode and outputting multiple lines at once.

@paescuj
Copy link
Collaborator

paescuj commented Aug 17, 2022

Hey @lneves12, I'm sorry that you have not received any feedback for such a long time!
Thank you very much for your contribution! ❤️

The screenshots you've provided look awesome 💯

Nevertheless, I'm afraid we cannot include this in its current state for various reasons (besides the obvious required updates):

  • In general, it seems to be too much in an "experimental state"
  • neo-blessed seems to be unmaintained - I'd like to avoid such dependencies
    (We'd need to look for an alternative, perhaps terminal-kit?)
  • More tests needs to be added
  • ...

That being said, this is not a general "no" to such a feature and I'd be pleased if you or someone else would like to continue working on this!

@paescuj
Copy link
Collaborator

paescuj commented May 21, 2023

Closing for now for the above reasons and because the pull request is outdated. Thanks anyway! ❤️ A new approach is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants