Make the SQL queries static

This simplifies the logic and makes it clearer what query is being made when reading the code. Signed-off-by: mprahl <[email protected]>
open-cluster-management-io · Jan 3, 2024 · ff3befc · ff3befc
1 parent 8a0fbb0
commit ff3befc
Show file tree

Hide file tree

Showing 3 changed files with 85 additions and 164 deletions.
diff --git a/controllers/complianceeventsapi/server.go b/controllers/complianceeventsapi/server.go
@@ -241,7 +241,7 @@ func getPolicyForeignKey(ctx context.Context, db *sql.DB, pol Policy) (int, erro
 
 	if pol.Spec == "" {
 		row := db.QueryRowContext(
-			ctx, fmt.Sprintf("SELECT spec FROM %s WHERE spec_hash = $1 LIMIT 1", policyTableName), pol.SpecHash,
+			ctx, "SELECT spec FROM policies WHERE spec_hash=$1 LIMIT 1", pol.SpecHash,
 		)
 		if row.Err() != nil {
 			return 0, fmt.Errorf("could not determine the spec from the provided spec hash: %w", row.Err())