Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix integration test random failure #815

Conversation

zhiweiyin318
Copy link
Member

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from ldpliu and xuezhaojun January 21, 2025 08:21
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.84%. Comparing base (a3ef1a7) to head (0d36e8d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
+ Coverage   63.82%   63.84%   +0.01%     
==========================================
  Files         193      193              
  Lines       18674    18674              
==========================================
+ Hits        11919    11922       +3     
+ Misses       5774     5772       -2     
+ Partials      981      980       -1     
Flag Coverage Δ
unit 63.84% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhiweiyin318 zhiweiyin318 force-pushed the fix-intergration-test branch 2 times, most recently from 6e26512 to febaefc Compare January 21, 2025 09:41
@zhiweiyin318
Copy link
Member Author

/assign @qiujian16

@zhiweiyin318 zhiweiyin318 force-pushed the fix-intergration-test branch from febaefc to 0d36e8d Compare January 21, 2025 12:59
@qiujian16
Copy link
Member

/approve
/assign @jaswalkiranavtar

Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaswalkiranavtar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 22, 2025
@jaswalkiranavtar
Copy link
Contributor

Thank you for fixing this

@openshift-merge-bot openshift-merge-bot bot merged commit c5f987e into open-cluster-management-io:main Jan 22, 2025
15 checks passed
@zhiweiyin318 zhiweiyin318 deleted the fix-intergration-test branch January 22, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants