-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Korbench #1713
Merged
Merged
Korbench #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaiziXiao
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR introduces the implementation of the KOR-Bench dataset and evaluator into the project. The goal is to support the evaluation of models on KOR-Bench tasks, enabling researchers and developers to assess model performance on various reasoning tasks in the Korean language.
Modification
Dataset Implementation:
korbenchDataset
class for loading and processing the KOR-Bench dataset.cipher
,logic
,operation
,puzzle
,counterfactual
, andmixed
) and modes (zero-shot
,three-shot
,subquestions
).read_yaml
,read_json_or_jsonl
, andread_json_or_jsonl_with_idx
to handle dataset files and configurations.Evaluator Implementation:
KorBenchEvaluator
class for evaluating model responses against the KOR-Bench benchmarks.evaluate_responses
andevaluate_response_vs_answer
to compare model outputs with ground truth answers.Utilities and Helper Functions:
extract_text_from_brackets
,compare_math_expressions
).Documentation and Testing:
BC-breaking (Optional)
This PR does not introduce any backward compatibility issues. Existing functionalities and modules remain unaffected.
Use cases (Optional)
Checklist
Before PR:
After PR: