-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support G-Pass@k and LiveMathBench #1772
Conversation
gen_config['temperature'] = temperature | ||
# gen_config['top_k'] = 40 | ||
# gen_config['temperature'] = temperature | ||
pass # use the parameters passed from gen_config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this modification will introduce BC? @MaiziXiao
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old implementation will overwrite top_k and temperature if 'do_sample','top_k' and 'temperature' are all set. This change will make sure 'top_k' and 'temperature' will not be overwritten.
@jnanliu We should remove these lines here
opencompass/configs/datasets/livemathbench/livemathbench_gen_9befbf.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
Support the evaluation using G-Pass@k metric and update the configurations of LiveMathBench.
Modification
turbomind_with_tf_above_v4_33.py
to ensure that gen_cfg of model_cfg is passed into the lmdeploy pipeline.openai_api.py
to print error url for ease of debugging.Checklist
Before PR: