[Feature] Update o1 evaluation with JudgeLLM #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaiziXiao
reviewed
Dec 30, 2024
Comment on lines
+16
to
+23
| def count_chinese_characters(text): | ||
| words = re.findall(r'[\u4e00-\u9fff]', text) | ||
| return len(words) | ||
|
|
||
|
|
||
| def count_english_words(text): | ||
| words = re.findall(r'\b[a-zA-Z]+\b', text) | ||
| return len(words) |
There was a problem hiding this comment.
What are these two functions for?
MaiziXiao
reviewed
Dec 30, 2024
Comment on lines
+42
to
+47
| Please judge whether the following answers are consistent with the standard answer based on the above criteria. Grade the predicted answer of this new question as one of: | ||
| A: CORRECT | ||
| B: INCORRECT | ||
| Just return the letters "A" or "B", with no text around it. | ||
|
|
||
| Here is your task. Simply reply with either CORRECT, INCORRECT. Don't apologize or correct yourself if there was a mistake; we are just trying to grade the answer. |
There was a problem hiding this comment.
Would the model be confused to reply "A | B" or "CORRECT | INCORRECT" with this evaluation prompt?
MaiziXiao
reviewed
Dec 30, 2024
Comment on lines
+104
to
+108
| if self.keep_judger_postfix: | ||
| return self.name_prefix + task_name + \ | ||
| '--judge-by--' + model_abbr_from_cfg(self.judge_cfg) | ||
| else: | ||
| return self.name_prefix + task_name |
There was a problem hiding this comment.
Any case we will set keep_judger_postfix to False?
liushz
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: