Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Code refactoarization #1831

Merged
merged 5 commits into from
Jan 20, 2025
Merged

[Refactor] Code refactoarization #1831

merged 5 commits into from
Jan 20, 2025

Conversation

MaiziXiao
Copy link
Collaborator

@MaiziXiao MaiziXiao commented Jan 17, 2025 •
edited
Loading

  1. Remove root folder configs
  2. Update pre-commit config
  3. Refactor Openai model class
  4. Remove EOS token id from vLLM class

@MaiziXiao MaiziXiao requested a review from tonysy January 17, 2025 02:21
tonysy
tonysy approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@tonysy tonysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaiziXiao MaiziXiao merged commit a6193b4 into open-compass:main Jan 20, 2025
8 checks passed
@MaiziXiao MaiziXiao mentioned this pull request Jan 20, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonysy tonysy tonysy approved these changes

Assignees

@tonysy tonysy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaiziXiao @tonysy