Lfpdisplaynode canvas split #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes aligning the trigger at the 1/4 point of the screen.
anjaldoshi
approved these changes
Mar 18, 2020
There was a problem hiding this comment.
Everything looks good. Just to confirm, this PR also includes all the commits from your original PR #337 related to adding event triggered display to LFP Viewer Beta. We tested this and the LFPDisplayCanvas split up, and everything seems to work fine. My question is, are you planning to or already working on merging your changes/features from beta to the main LFP Viewer? If so, do you want any help from us?
Also, I'm gonna close PR #337 after merging this because of the reason mentioned above.
Closed
|
Hi Anjal,
Yes, this PR includes previous commits, but to my knowledge they had
already been accepted into development.
I am already working on merging my previous changes to the
LfpViewerNodeBeta into the LfpViewerNode. So far, I am not encountering
any obstacles. If that changes, I'll be sure to reach out.
Thanks!
- Daniel
…On 3/18/20 4:25 PM, anjaldoshi wrote:
***@***.**** approved this pull request.
Everything looks good. Just to confirm, this PR also includes all the
commits from your original PR #337
<#337> related to adding
event triggered display to LFP Viewer Beta. We tested this and the
LFPDisplayCanvas split up, and everything seems to work fine. My
question is, are you planning to or already working on merging your
changes/features from beta to the main LFP Viewer? If so, do you want
any help from us?
Also, I'm gonna close PR #337
<#337> after merging this
because of the reason mentioned above.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#344 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZHS66YM6ZVOX2KQZ6IN2TRIFJ7HANCNFSM4LOVY6ZQ>.
|
|
Alright, sounds good! Thanks for your continued contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split up the giant files LfpDisplayCanvas.h and LfpDisplayCanvas.cpp in the "regular" LfpViewer plugin into their constituent classes. This pull request makes no other changes whatsoever and has no runtime impact of any sort. I would greatly appreciate it if you could merge this quickly, because rebasing this patch is not trivial.
Thanks!