Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toast updates #405

Merged
merged 6 commits into from
Dec 9, 2023
Merged

Toast updates #405

merged 6 commits into from
Dec 9, 2023

Conversation

trippjoe
Copy link
Member

@trippjoe trippjoe commented Dec 6, 2023 •
edited
Loading

Toast improvements:

  • Icon and color based on toast level (info, warn, error)
  • Animates out
  • Made it a component, removing logic from app.svelte
  • handles multiple toast messages better using a queue

Sidebar styling logic:
This was kinda gross so I revised it a bit. I'm considering doing an overhaul of the sidebar in the future.

@trippjoe trippjoe changed the title Misc changes Toast updates Dec 6, 2023
@trippjoe trippjoe marked this pull request as ready for review December 6, 2023 20:58
@trippjoe trippjoe linked an issue Dec 6, 2023 that may be closed by this pull request
Toast errors disappear too quickly if triggered before the previous one fully dies #122
Closed
@trippjoe trippjoe requested a review from xTVaser December 7, 2023 01:20
@trippjoe trippjoe merged commit 0cfbd36 into main Dec 9, 2023
8 checks passed
@trippjoe trippjoe deleted the misc-changes branch December 9, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xTVaser xTVaser Awaiting requested review from xTVaser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toast errors disappear too quickly if triggered before the previous one fully dies
1 participant
@trippjoe