Skip to content

Commit

Permalink
Minor: supporting PR for UI/UX improvement in DQ (#18663)
Browse files Browse the repository at this point in the history
* Minor: supporting PR for UI/UX improvement in DQ

* updated feedback

* move incidents tab to data observabilty tab

* fixed failing unit test

* fixed failing unit test

* fixed AUT failure!

* fixed failing aut

* minor fixes

* minor fix

* updated icon

* fixed failing unit test
  • Loading branch information
ShaileshParmar11 authored Nov 21, 2024
1 parent fca85cd commit cda201b
Show file tree
Hide file tree
Showing 55 changed files with 464 additions and 140 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -392,12 +392,16 @@ test.describe('Incident Manager', PLAYWRIGHT_INGESTION_TAG_OBJ, () => {

test('Validate Incident Tab in Entity details page', async ({ page }) => {
const testCases = table1.testCasesResponseData;
await table1.visitEntityPage(page);
await visitProfilerTab(page, table1);

const incidentListResponse = page.waitForResponse(
`/api/v1/dataQuality/testCases/testCaseIncidentStatus?*originEntityFQN=${table1.entityResponseData?.['fullyQualifiedName']}*`
);

await page.click('[data-testid="incidents"]');
await page
.getByTestId('profiler-tab-left-panel')
.getByText('Incidents')
.click();
await incidentListResponse;

for (const testCase of testCases) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ test(
const pipelineName = `test suite pipeline 2`;

await test.step('Create a new pipeline', async () => {
await page.getByText('Profiler & Data Quality').click();
await page.getByText('Data Observability').click();
await page
.getByRole('menuitem', {
name: 'Table Profile',
Expand Down Expand Up @@ -204,7 +204,7 @@ test(
testCaseNames
);
await table.visitEntityPage(page);
await page.getByText('Profiler & Data Quality').click();
await page.getByText('Data Observability').click();
await page.getByRole('menuitem', { name: 'Data Quality' }).click();

await page.getByRole('tab', { name: 'Pipeline' }).click();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ test.describe('Tour should work properly', () => {

await expect(page.locator(`[data-tour-elem="badge"]`)).toHaveText('12');

await expect(page.getByText('Profiler & Data Quality')).toBeVisible();
await expect(page.getByText('Data Observability')).toBeVisible();

// step 11
await page.locator('[data-tour-elem="right-arrow"]').click();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ test('Table difference test case', async ({ page }) => {
table1.entityResponseData?.['fullyQualifiedName']
)}/tableProfile/latest`
);
await page.getByText('Profiler & Data Quality').click();
await page.getByText('Data Observability').click();
await profileResponse;
await page.getByRole('menuitem', { name: 'Table Profile' }).click();

Expand Down Expand Up @@ -170,7 +170,7 @@ test('Custom SQL Query', async ({ page }) => {
table.entityResponseData?.['fullyQualifiedName']
)}/tableProfile/latest`
);
await page.getByText('Profiler & Data Quality').click();
await page.getByText('Data Observability').click();
await profileResponse;
await page.getByRole('menuitem', { name: 'Table Profile' }).click();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export const validateViewPermissions = async (
await page.waitForLoadState('domcontentloaded');
await checkNoPermissionPlaceholder(
page,
/Profiler & Data Quality/,
/Data Observability/,
permission?.viewTests
);
await page.click('[data-testid="lineage"]');
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit cda201b

Please sign in to comment.