Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #17036: Ignore Enter keydown events for IME operation on FeedEditor #17150

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Conversation

fuzmish
Copy link
Contributor

@fuzmish fuzmish commented Jul 23, 2024

Describe your changes:

Fixes #17036

Type of change:

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

Phylum OSS Supply Chain Risk Analysis - SUCCESS

The Phylum risk analysis is complete and has passed the active policy.

View this project in the Phylum UI

Copy link
Contributor

github-actions bot commented Jul 23, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.02% (36710/56460) 41.61% (14531/34921) 43.76% (4462/10196)

Copy link
Contributor

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @fuzmish 🙌🏻,
Thanks for the contributions ✨

Copy link

@Sachin-chaurasiya Sachin-chaurasiya merged commit 5351858 into open-metadata:main Jul 31, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI issue for Chinese/Japanese/Korean (CJK) text input
3 participants