Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SSO] Google returns null refresh token on Refresh requests #18868

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[SSO] Google returns null refresh token on Refresh requests #18868

merged 1 commit into from
Dec 2, 2024

Conversation

mohityadav766
Copy link
Contributor

Describe your changes:

  • On Refresh requests , google sso returns null for refresh tokens
  • Null refresh tokens needs to be ignored

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 self-assigned this Dec 2, 2024
@mohityadav766 mohityadav766 requested a review from a team as a code owner December 2, 2024 05:23
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Dec 2, 2024
@mohityadav766 mohityadav766 merged commit dc4b2c9 into main Dec 2, 2024
7 of 17 checks passed
@mohityadav766 mohityadav766 deleted the fix-google-sso branch December 2, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

Assignees

@mohityadav766 mohityadav766

Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohityadav766 @chirag-madlani