Upgrade go dependencies #167
Conversation
Upgrade core k8s libraries to be the same as the ones required for gatekeeper. Also upgrade others. No changes to our code required. Signed-off-by: Will Beason <[email protected]>
willbeason
requested review from
sozercan,
srenatus,
julianKatz and
maxsmythe
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
=======================================
Coverage 44.98% 44.98%
=======================================
Files 59 59
Lines 2794 2794
=======================================
Hits 1257 1257
Misses 1295 1295
Partials 242 242
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Looks good to me. The OPA bump will get you open-policy-agent/opa#2092, which has mentioned some GK security audit from the past, just a heads-up. You may want to have a closer look.
|
@willbeason looks like there is vendor inconsistency in gk test |
That's because of the changes to frameworks/. As the dependencies of frameworks/ change, if frameworks/ is the only reason they are included in gatekeeper/ then this inconsistency will arise as the "correct" contents of vendor/ for gatekeeper/ will change. There isn't a (sane) way to do this without breaking that test. |
|
@willbeason I see. Is the plan to open a corresponding PR to vendor latest frameworks into GK once this PR merges? |
Yep! |
|
I'll merge in a couple hours - I'll have time then to send out a PR that resolves the resulting gatekeeper conflicts. |
|
Merging now; I'll send out a PR for gatekeeper momentarily. |
Upgrade core k8s libraries to be the same as the ones required for
gatekeeper. Also upgrade others.
No changes to our code required.
Signed-off-by: Will Beason [email protected]