Add support for print built-in #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
- Coverage 44.92% 44.91% -0.01%
==========================================
Files 59 59
Lines 2776 2783 +7
==========================================
+ Hits 1247 1250 +3
- Misses 1286 1290 +4
Partials 243 243
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
anderseknert
force-pushed
the
allow-print
branch
from
9e9cece to
ca8491c
Compare
srenatus
approved these changes
Jan 10, 2022
|
@srenatus did you miss to post that nitpick? I can't find it 😄 |
srenatus
reviewed
Jan 10, 2022
While playing around with the Gator CLI today I noticed that I couldn't use the new print built-in from OPA in that context. This function is really useful to quickly be able to debug values of rules and variables, and would be a nice addition to the Gator CLI (and possibly to the Gatekeeper server too, but others can decide that). This PR adds options to the local driver for enabling print and for providing a printHook that decides where the output of print calls should go. Will submit another PR for support in Gator if/when this is merged. Signed-off-by: Anders Eknert <[email protected]>
anderseknert
force-pushed
the
allow-print
branch
from
ca8491c to
238549a
Compare
srenatus
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing around with the Gator CLI today I noticed
that I couldn't use the new print built-in from OPA in that
context. This function is really useful to quickly be able to
debug values of rules and variables, and would be a nice
addition to the Gator CLI (and possibly to the Gatekeeper
server too, but others can decide that). This PR adds options
to the local driver for enabling print and for providing a
printHook that decides where the output of print calls should
go. Will submit another PR for support in Gator if/when this
is merged.
Signed-off-by: Anders Eknert [email protected]