Refactor out backend code #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the backend intermediate type for instantiating and using Client adds complexity, code length, and unnecessary error paths. This commit fully removes backend without breaking any existing funcitonality. Signed-off-by: Will Beason <[email protected]>
Signed-off-by: Will Beason <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
- Coverage 48.10% 47.88% -0.22%
==========================================
Files 59 59
Lines 2871 2865 -6
==========================================
- Hits 1381 1372 -9
- Misses 1241 1243 +2
- Partials 249 250 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Will Beason <[email protected]>
|
Note that Gatekeeper failing is expected since backend instantiation changed. I'll send a PR to fix in gatekeeper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers: This changes how Client is instantiated, so it breaks
Gatekeeper's usage of it. This can easily be remedied with a small change
to the Gatekeeper repo.
Having the backend intermediate type for instantiating and using Client
adds complexity, code length, and unnecessary error paths. This change
makes using Client easier and streamlines options to a single type, all
specified when instantiating the Client.
This commit fully removes backend without breaking any existing
funcitonality.
Signed-off-by: Will Beason [email protected]