-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add externaldata v1beta1 api #270
feat: add externaldata v1beta1 api #270
Conversation
Signed-off-by: Sertac Ozercan <[email protected]>
Signed-off-by: Sertac Ozercan <[email protected]>
Signed-off-by: Sertac Ozercan <[email protected]>
Signed-off-by: Sertac Ozercan <[email protected]>
Signed-off-by: Sertac Ozercan <[email protected]>
b82f91d
to
f4198ff
Compare
Signed-off-by: Sertac Ozercan <[email protected]>
f4198ff
to
86cbcbc
Compare
Signed-off-by: Sertac Ozercan <[email protected]>
Codecov ReportBase: 50.39% // Head: 49.30% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #270 +/- ##
==========================================
- Coverage 50.39% 49.30% -1.10%
==========================================
Files 64 69 +5
Lines 4274 4468 +194
==========================================
+ Hits 2154 2203 +49
- Misses 1881 2021 +140
- Partials 239 244 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Sertac Ozercan <[email protected]>
constraint/config/crds/externaldata.gatekeeper.sh_providers.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Sertac Ozercan <[email protected]>
Signed-off-by: Sertac Ozercan <[email protected]>
50804f4
to
5c99019
Compare
Signed-off-by: Sertac Ozercan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Why is gatekeeper_test broken? |
Supposed to be broken (it's a signal, not a pr gate). open-policy-agent/gatekeeper#2438 addresses those |
Signed-off-by: Sertac Ozercan <[email protected]>
@ritazh good to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Sertac Ozercan [email protected]
GK PR: open-policy-agent/gatekeeper#2438