Workaround helm template bug when testing for APIVersions #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1533 +/- ##
==========================================
- Coverage 53.35% 53.25% -0.11%
==========================================
Files 84 84
Lines 7547 7547
==========================================
- Hits 4027 4019 -8
- Misses 3163 3168 +5
- Partials 357 360 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sathieu
force-pushed
the
workaround_helm_template
branch
2 times, most recently
from
5c8ca7b to
5f7f16d
Compare
Signed-off-by: Mathieu Parent <[email protected]>
sathieu
force-pushed
the
workaround_helm_template
branch
from
5f7f16d to
562342f
Compare
ritazh
approved these changes
Sep 7, 2021
koozz
approved these changes
Sep 7, 2021
maxsmythe
approved these changes
Sep 8, 2021
5 tasks
|
for reference, the whole picture is at argoproj/argo-cd#7291. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#1502 broke gatekeeper installation with ArgoCD.
The reason is ArgoCD is using
helm templatecommand, passing all supported APIVersions, but Helm pre-fill this with the supported versions of the Kubernetes used during helm build (i.e. k8s 1.21).There are a few related bug reports like in argoproj/argo-cd#6351, argoproj/argo-cd#3594.
This PR change the behavior to match on exact resource type, as Helm is not pre-filling those.
Other possible workarounds include:
{{- if .Capabilities.APIVersions.Has "policy/v1beta1" }}(will still raise deprecation warnings)Side node:
The behavior of
helm templateshould also be fixed when--api-versionis passed.