Expose two Read methods in gktest #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianKatz
requested review from
shomron,
sozercan,
ritazh,
willbeason and
maxsmythe
willbeason
approved these changes
Nov 8, 2021
Signed-off-by: juliankatz <[email protected]>
Signed-off-by: juliankatz <[email protected]>
Signed-off-by: juliankatz <[email protected]>
Signed-off-by: juliankatz <[email protected]>
Signed-off-by: juliankatz <[email protected]>
I have an opportunity to re-use code made written in gktest, as long as the necessary functions are public. This PR makes the following two functions in the gktest package public. They are (with their newly capitalized names): - ReadTemplate() - ReadObject() Signed-off-by: juliankatz <[email protected]>
julianKatz
force-pushed
the
refactor-read-constraint-in-gator
branch
from
6d755b8 to
fc0af6e
Compare
maxsmythe
approved these changes
Nov 10, 2021
ritazh
reviewed
Nov 10, 2021
| @@ -72,13 +71,10 @@ func readUnstructured(bytes []byte) (*unstructured.Unstructured, error) { | |||
| return u, nil | |||
| } | |||
|
|
|||
| // TODO(willbeason): Remove once ToVersionless() is threadsafe. | |||
There was a problem hiding this comment.
Is this threadsafe now to remove the lock?
There was a problem hiding this comment.
There was a problem hiding this comment.
I've also confirmed that these frameworks changes are in gatekeeper already
… refactor-read-constraint-in-gator Signed-off-by: juliankatz <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1651 +/- ##
==========================================
+ Coverage 52.05% 52.16% +0.11%
==========================================
Files 98 98
Lines 8693 8691 -2
==========================================
+ Hits 4525 4534 +9
+ Misses 3806 3798 -8
+ Partials 362 359 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
… refactor-read-constraint-in-gator Signed-off-by: juliankatz <[email protected]>
… refactor-read-constraint-in-gator Signed-off-by: juliankatz <[email protected]>
ritazh
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an opportunity to re-use code made written in gktest, as long as
the necessary functions are public. This PR makes the following two
functions in the gktest package public. They are (with their newly
capitalized names):
Signed-off-by: juliankatz [email protected]