Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for audit to writeToRAMDisk to chart #1660

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Nov 11, 2021

Signed-off-by: Rita Zhang [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021

Codecov Report

Merging #1660 (bc41d7b) into master (c2119e8) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1660      +/-   ##
==========================================
- Coverage   52.20%   52.19%   -0.02%     
==========================================
  Files          98       98              
  Lines        8693     8693              
==========================================
- Hits         4538     4537       -1     
  Misses       3797     3797              
- Partials      358      359       +1     
Flag Coverage Δ
unittests 52.19% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/config/config_controller.go 65.04% <0.00%> (-1.33%) ⬇️
pkg/readiness/object_tracker.go 82.91% <0.00%> (-1.07%) ⬇️
pkg/readiness/ready_tracker.go 69.83% <0.00%> (-0.51%) ⬇️
...onstrainttemplate/constrainttemplate_controller.go 59.71% <0.00%> (+0.94%) ⬆️
pkg/readiness/list.go 91.17% <0.00%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2119e8...bc41d7b. Read the comment docs.

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit f43223e into open-policy-agent:master Nov 11, 2021
@ritazh ritazh deleted the chart-auditramdisk branch November 11, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants