Close #248 : extraVolumes not working if either authz or bootstrapPolicies are not enabled;
#249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshepelyuk
requested changes
Mar 11, 2024
There was a problem hiding this comment.
This change require unit test coverage.
https://github.com/open-policy-agent/kube-mgmt/tree/master/test%2Funit
|
Done 👌 |
eshepelyuk
requested changes
Mar 12, 2024
There was a problem hiding this comment.
plz
- rebase and squash the or to have a single commit.
- adjust commit message to properly link to original issue, as described
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
…thz` or `bootstrapPolicies` are not enabled; Signed-off-by: Romain Caire <[email protected]>
supercairos
force-pushed
the
rcaire/fix-bootstrap
branch
from
67ddf98 to
d836aa4
Compare
supercairos
changed the title
extraVolumes not working if either authz or bootstrapPolicies are not enabled;extraVolumes not working if either authz or bootstrapPolicies are not enabled;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #248