Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PerfWrapper does not handle spaces in paths #23

Open
RobbeDGreef opened this issue May 17, 2024 · 1 comment
Open

PerfWrapper does not handle spaces in paths #23

RobbeDGreef opened this issue May 17, 2024 · 1 comment
Assignees
Labels
bug Something isn't working planned shellout Changes to the internal of executing something on the shell;

Comments

@RobbeDGreef
Copy link
Collaborator

RobbeDGreef commented May 17, 2024

If you have a path that contains a space, the perf wrapper will throw an error and fail because it performs commands using the shell_out function and passes this function a string where it simply concatinates all the arguments.
The shell_out function will then split the string into arguments, but in doing so, split a path that contains a space into two separate arguments instead of one path as an argument.

This will then fail in the various command line tools that it calls.

This also means that you will get errors if you put a space in your CampaignCartesianProduct benchmark name because it uses this name to generate a folder for the output.
If you get this error because you have a space in the path leading to your campaign due to a folder with a space in it then you brought this on yourself because who does such a thing :P

@apaolillo
Copy link
Collaborator

Aaah these spaces in paths.. ruining everything :D
With @aaronbog we are working on a revamp of the "shelling out" low-level implementation. These issues should disappear in the new version.

@apaolillo apaolillo self-assigned this Aug 10, 2024
@apaolillo apaolillo added shellout Changes to the internal of executing something on the shell; planned bug Something isn't working labels Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working planned shellout Changes to the internal of executing something on the shell;
Projects
None yet
Development

No branches or pull requests

3 participants