Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/clip post lapse stability #142

Merged
merged 5 commits into from
Dec 17, 2024
Merged

Conversation

ishiko732
Copy link
Collaborator

I switched to a different implementation method, directly modifying the next_forget_stability method. The commit is f855a02.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f0b1369) to head (ecbe9e4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #142   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          688       689    +1     
  Branches        76        76           
=========================================
+ Hits           688       689    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@L-M-Sherlock L-M-Sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishiko732 ishiko732 linked an issue Dec 17, 2024 that may be closed by this pull request
@ishiko732 ishiko732 merged commit af8f873 into main Dec 17, 2024
5 checks passed
@ishiko732 ishiko732 deleted the Fix/clip-post-lapse-stability branch December 17, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TODO] clip post-lapse stability
2 participants