[oracledb] Max tablespace size may be unset

[atoulme]

Component(s)

receiver/oracledb

What happened?

Description

A database table space may be configured to have no max_extents, which translates to a null value when we calculate the max size of table space. This creates an issue when we scrape the metric as the string value returned is "".

We should aim to explicitly manage this use case, possibly by setting a -1 value instead or another approach that clearly indicates that the max value is set.

Collector version

0.71.0

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

[crobert-1]

Can you explain what happens when it's an empty string, and how that negatively impacts the user?

The thought makes sense to mark it explicitly when it's not set, but I'm curious what the current impact is.

[atoulme]

They get a scraping partial error, which indicates that there was a failure to retrieve the metric value:

Feb 09 08:40:06 cmtdb1d otelcol[100719]: 2023-02-09T08:40:06.763-0600       error       scraperhelper/scrapercontroller.go:212       Error scraping metrics       {"kind": "receiver", "name": "oracledb/2", "pipeline": "metrics", "error": "failed to parse int64 for OracledbTablespaceSizeLimit, value was : strconv.ParseInt: parsing \"\": invalid syntax", "scraper": "oracledb/2"}
Feb 09 08:40:06 cmtdb1d otelcol[100719]: go.opentelemetry.io/collector/receiver/scraperhelper.(*controller).scrapeMetricsAndReport
Feb 09 08:40:06 cmtdb1d otelcol[100719]: go.opentelemetry.io/[email protected]/receiver/scraperhelper/scrapercontroller.go:212
Feb 09 08:40:06 cmtdb1d otelcol[100719]: go.opentelemetry.io/collector/receiver/scraperhelper.(*controller).startScraping.func1
Feb 09 08:40:06 cmtdb1d otelcol[100719]: go.opentelemetry.io/[email protected]/receiver/scraperhelper/scrapercontroller.go:191
Feb 09 08:40:06 cmtdb1d otelcol[100719]: 2023-02-09T08:40:06.776-0600       error       scraperhelper/scrapercontroller.go:212       Error scraping metrics       {"kind": "receiver", "name": "oracledb/0", "pipeline": "metrics", "error": "failed to parse int64 for OracledbTablespaceSizeLimit, value was : strconv.ParseInt: parsing \"\": invalid syntax", "scraper": "oracledb/0"}
Feb 09 08:40:06 cmtdb1d otelcol[100719]: go.opentelemetry.io/collector/receiver/scraperhelper.(*controller).scrapeMetricsAndReport
Feb 09 08:40:06 cmtdb1d otelcol[100719]: go.opentelemetry.io/[email protected]/receiver/scraperhelper/scrapercontroller.go:212
Feb 09 08:40:06 cmtdb1d otelcol[100719]: go.opentelemetry.io/collector/receiver/scraperhelper.(*controller).startScraping.func1
Feb 09 08:40:06 cmtdb1d otelcol[100719]: go.opentelemetry.io/[email protected]/receiver/scraperhelper/scrapercontroller.go:191

[crobert-1]

Good catch, thanks for including the error!