-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/loki]: Attribute used as hint always added as loki label #21045
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
That's a good question.
I think setting |
Probably an oversight, I agree the tenant should not be automatically promoted to a label. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
still relevant |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
still relevant |
Fixes open-telemetry#21045 Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Fixes #21045 Signed-off-by: Juraci Paixão Kröhling <[email protected]> --------- Signed-off-by: Juraci Paixão Kröhling <[email protected]>
…7446) Fixes open-telemetry#21045 Signed-off-by: Juraci Paixão Kröhling <[email protected]> --------- Signed-off-by: Juraci Paixão Kröhling <[email protected]>
…7446) Fixes open-telemetry#21045 Signed-off-by: Juraci Paixão Kröhling <[email protected]> --------- Signed-off-by: Juraci Paixão Kröhling <[email protected]>
…7446) Fixes open-telemetry#21045 Signed-off-by: Juraci Paixão Kröhling <[email protected]> --------- Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Component(s)
exporter/loki
Describe the issue you're reporting
It seems like when I add a hint for org-id using
loki.tenant
it also becomes added as a loki label. This seems like an unnecessary overhead since it will always have the same value for the same tenant.For example if I use the
k8s.namespace.name
resource attribute forloki.tenant
it will also add a loki label calledk8s_namespace_name
which will always have the same value within the tenant.Is automatcially adding a loki label for the
loki.tenant
hint value expected behavior or do I have a misconfiguration?The text was updated successfully, but these errors were encountered: