Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[connector/servicegraph] Tests consistently failing on Windows #33836

Closed
pjanotti opened this issue Jul 1, 2024 · 2 comments
Closed

[connector/servicegraph] Tests consistently failing on Windows #33836

pjanotti opened this issue Jul 1, 2024 · 2 comments
Labels
connector/servicegraph needs triage New item requiring triage

Comments

@pjanotti
Copy link
Contributor

pjanotti commented Jul 1, 2024 •
edited
Loading

Component(s)

connector/servicegraph

Describe the issue you're reporting

These tests are consistently failing on Windows, possibly due timing issues similar to this one

=== FAIL: . TestVirtualNodeServerLabels (0.11s)
    logger.go:146: 2024-07-01T22:14:18.755Z	INFO	Started servicegraphconnector
    connector_test.go:515: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/connector/servicegraphconnector/connector_test.go:515
        	Error:      	Condition never satisfied
        	Test:       	TestVirtualNodeServerLabels
    logger.go:146: 2024-07-01T22:14:18.860Z	INFO	Shutting down servicegraphconnector
    connector_test.go:521: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/connector/servicegraphconnector/connector_test.go:521
        	Error:      	"0" is not greater than or equal to "1"
        	Test:       	TestVirtualNodeServerLabels

=== FAIL: . TestVirtualNodeClientLabels (0.11s)
    logger.go:146: 2024-07-01T22:14:18.861Z	INFO	Started servicegraphconnector
    connector_test.go:559: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/connector/servicegraphconnector/connector_test.go:559
        	Error:      	Condition never satisfied
        	Test:       	TestVirtualNodeClientLabels
    logger.go:146: 2024-07-01T22:14:18.970Z	INFO	Shutting down servicegraphconnector
    connector_test.go:565: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/connector/servicegraphconnector/connector_test.go:565
        	Error:      	"0" is not greater than or equal to "1"
make[2]: *** [../../Makefile.Common:126: test] Error 1

https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/9751668196/job/26913739491?pr=33815
@pjanotti pjanotti added the needs triage New item requiring triage label Jul 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@pjanotti pjanotti mentioned this issue Jul 1, 2024
Merged
@github-actions github-actions bot mentioned this issue Jul 2, 2024
Closed
dmitryax pushed a commit that referenced this issue Jul 2, 2024
@pjanotti
Skip failing Windows tests (#33837)
dfd127b 
Skip failing Windows tests, see #33836
@pjanotti
Copy link
Contributor Author

pjanotti commented Jul 2, 2024

This is a duplicate of #33679

@pjanotti pjanotti closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
connector/servicegraph needs triage New item requiring triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pjanotti