-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker image in examples/demo from 0.88.0 to 0.116.0 #37031
Comments
Updating the version makes sense to me, feel free to open a PR if you're interested! |
Pinging code owners for examples/demo: @open-telemetry/collector-approvers. See Adding Labels via Comments if you do not have permissions to add labels yourself. For example, comment '/label priority:p2 -needs-triaged' to set the priority and remove the needs-triaged label. |
@crobert-1 PR opened. Do I need to run any additional tests or steps ? I have this doubt because it's not related to the collector code itself, and it's not a new component. |
Looks good to me! Your testing was great in my opinion, thanks! |
Describe the issue you're reporting
Update docker image and configuration for example from
otel/opentelemetry-collector:0.88.0
tootel/opentelemetry-collector:0.116.0
Component(s)
examples/demo
Description:
I would like to update the docker image used in the example from
otel/opentelemetry-collector:0.88.0
tootel/opentelemetry-collector:0.116.0
. This update requires some changes to the collector configuration (otel-collector-config.yaml
) due to a breaking change in the collector. In version0.116.0
, the collector no longer exposes configurations on0.0.0.0
by default.To ensure that the example works with the current setup using Docker Compose, I will need to add the following configuration:
These changes are necessary for compatibility with the updated version of the collector. I have already tested the proposed changes, and everything worked as expected. Additionally, if it aligns with the goals of the example, there is an opportunity to include Service Performance Monitoring (SPM) in the Jaeger configuration, given that the example focuses on metrics. This is just a suggestion for further enhancement.
Additional context
I found the issue #16613, created in 2023 with the never stale label, which proposed some corrections to the collector configuration. Upon review, it appears these corrections have already been implemented. I would like to propose closing this issue since the solution has been applied. Additionally, I suggest updating the example configuration with a new pull request linked to this issue. If neither of these actions is deemed appropriate, it would make sense to close both the current issue and #16613 to avoid redundancy and ensure clarity in project tracking.
The text was updated successfully, but these errors were encountered: