Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker image in examples/demo from 0.88.0 to 0.116.1 (Closes #37031) #37063

Merged

Conversation

apolzek
Copy link
Contributor

@apolzek apolzek commented Jan 7, 2025

Update docker image and collector configuration in examples/demo to keep metrics working on port 8888

The gap between versions 0.88.0 and 0.116.1 is widening

Description

Update docker image used in the example from otel/opentelemetry-collector:0.88.0 to otel/opentelemetry-collector:0.116.1. This update requires some changes to the collector configuration (otel-collector-config.yaml) due to a breaking change in the collector. In version 0.116.1, the collector no longer exposes configurations on 0.0.0.0 by default.

Collector configuration to keep metrics working on port 8888

  telemetry:
    metrics:
      readers:
        - pull:
            exporter:
              prometheus:
                host: '0.0.0.0'
                port: 8888

Link to tracking issue

Closes #37031

Testing

  • Traces are exactly the same in Jaeger after updating the image/config
  • Traces are exactly the same in Zipkin after updating the image/config
  • Metrics endpoint 8889 is working /metrics
  • Metrics endpoint 8888 is working /metrics (after adjustment in the collector at service/telemetry/metrics/readers)
cd examples/demo/ && docker compose up

✔️ All services are up and running
✔️ Metric logs are visible
✔️ Trace logs are visible
✔️ Client and server tracing are available in both Zipkin and Jaeger

otel-collector-1     | 2025-01-07T10:43:29.029Z info    Traces  {"kind": "exporter", "data_type": "traces", "name": "debug", "resource spans": 1, "spans": 8}
otel-collector-1     | 2025-01-07T10:43:29.029Z info    Metrics {"kind": "exporter", "data_type": "metrics", "name": "debug", "resource metrics": 1, "metrics": 7, "data points": 7}

Update collector configuration to keep metrics working on port 8888
@apolzek apolzek requested a review from a team as a code owner January 7, 2025 10:47
@apolzek apolzek requested a review from fatsheep9146 January 7, 2025 10:47
Copy link

linux-foundation-easycla bot commented Jan 7, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@songy23 songy23 added dependencies Pull requests that update a dependency file Skip Changelog PRs that do not require a CHANGELOG.md entry labels Jan 7, 2025
@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Jan 7, 2025
Co-authored-by: Curtis Robert <[email protected]>
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.63%. Comparing base (165a18f) to head (556352e).
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #37063   +/-   ##
=======================================
  Coverage   79.62%   79.63%           
=======================================
  Files        2224     2224           
  Lines      210393   210393           
=======================================
+ Hits       167530   167541   +11     
+ Misses      37244    37237    -7     
+ Partials     5619     5615    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest moving this configuration from .env into the docker compose file directly so that renovate can keep this updated in the future

@songy23 songy23 requested a review from codeboten January 8, 2025 21:45
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codeboten codeboten merged commit e102cf0 into open-telemetry:main Jan 8, 2025
161 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file examples/demo ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docker image in examples/demo from 0.88.0 to 0.116.0
6 participants