-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker image in examples/demo from 0.88.0 to 0.116.1 (Closes #37031) #37063
Update docker image in examples/demo from 0.88.0 to 0.116.1 (Closes #37031) #37063
Conversation
Update collector configuration to keep metrics working on port 8888
Co-authored-by: Curtis Robert <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37063 +/- ##
=======================================
Coverage 79.62% 79.63%
=======================================
Files 2224 2224
Lines 210393 210393
=======================================
+ Hits 167530 167541 +11
+ Misses 37244 37237 -7
+ Partials 5619 5615 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest moving this configuration from .env into the docker compose file directly so that renovate can keep this updated in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Update docker image and collector configuration in examples/demo to keep metrics working on port 8888
The gap between versions 0.88.0 and 0.116.1 is widening
Description
Update docker image used in the example from otel/opentelemetry-collector:0.88.0 to otel/opentelemetry-collector:0.116.1. This update requires some changes to the collector configuration (otel-collector-config.yaml) due to a breaking change in the collector. In version 0.116.1, the collector no longer exposes configurations on 0.0.0.0 by default.
Collector configuration to keep metrics working on port 8888
Link to tracking issue
Closes #37031
Testing
✔️ All services are up and running
✔️ Metric logs are visible
✔️ Trace logs are visible
✔️ Client and server tracing are available in both Zipkin and Jaeger