Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark tests #1399

Merged

Conversation

kohrapha
Copy link
Contributor

Description:
This CR adds benchmarking tests for the AWS EMF Exporter.

Testing:
The new benchmarking tests were run locally.

Documentation:
N/A

@kohrapha kohrapha requested a review from anuraaga as a code owner October 27, 2020 20:45
@kohrapha kohrapha requested a review from a team October 27, 2020 20:45
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #1399 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1399      +/-   ##
==========================================
- Coverage   89.87%   89.86%   -0.02%     
==========================================
  Files         328      328              
  Lines       16081    16081              
==========================================
- Hits        14453    14451       -2     
- Misses       1184     1185       +1     
- Partials      444      445       +1     
Flag Coverage Δ
#integration 68.89% <ø> (ø)
#unit 89.11% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
receiver/k8sclusterreceiver/watcher.go 95.29% <0.00%> (-2.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af2a41...237d7fc. Read the comment docs.

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tigrannajaryan
Copy link
Member

Please rebase. Failing tests should pass now.

@kohrapha kohrapha force-pushed the kohrapha/upstream-merge branch from e01c048 to 237d7fc Compare October 28, 2020 16:14
@kohrapha
Copy link
Contributor Author

@tigrannajaryan done!

@tigrannajaryan tigrannajaryan merged commit 7b6806f into open-telemetry:master Oct 28, 2020
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants