Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated stackdriver exporter #1427

Merged
merged 4 commits into from
Nov 1, 2020
Merged

Updated stackdriver exporter #1427

merged 4 commits into from
Nov 1, 2020

Conversation

james-bebbington
Copy link
Member

@james-bebbington james-bebbington commented Oct 30, 2020 •
edited
Loading

Description:

  • Update stackdriver exporter to v0.13.0
  • Add config to allow trace bundle settings to be configured

Breaking Changes:

cc @nilebox @dashpole

@james-bebbington james-bebbington requested a review from a team October 30, 2020 00:56
@james-bebbington
Copy link
Member Author

FYI @igorpeshansky @qingling128 - this would have been a good issue to get you to look into in hindsight

@codecov
Copy link

codecov bot commented Oct 30, 2020 •
edited
Loading

Codecov Report

Merging #1427 into master will decrease coverage by 0.00%.
The diff coverage is 87.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1427      +/-   ##
==========================================
- Coverage   88.74%   88.74%   -0.01%     
==========================================
  Files         343      343              
  Lines       16693    16728      +35     
==========================================
+ Hits        14815    14846      +31     
- Misses       1417     1421       +4     
  Partials      461      461
Flag Coverage Δ
integration 70.80% <ø> (-0.08%) ⬇️
unit 87.38% <87.17%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/stackdriverexporter/spandata.go 75.92% <50.00%> (-2.51%) ⬇️
exporter/stackdriverexporter/stackdriver.go 75.19% <96.77%> (+7.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e364cc2...02206a1. Read the comment docs.

tigrannajaryan
tigrannajaryan reviewed Oct 30, 2020
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the config is change it would be useful to describe it in the CHANGELOG's Breaking Changes section.

Also, see if you can increase the coverage, the new code seems mostly uncovered.

@james-bebbington
Copy link
Member Author

Since the config is change it would be useful to describe it in the CHANGELOG's Breaking Changes section.

Added

Also, see if you can increase the coverage, the new code seems mostly uncovered.

Extended the tests to cover various bundling configuration options

bogdandrutu
bogdandrutu approved these changes Nov 1, 2020
View reviewed changes
exporter/stackdriverexporter/config.go
Comment on lines +47 to +53
type TraceConfig struct {
BundleDelayThreshold time.Duration `mapstructure:"bundle_delay_threshold"`
BundleCountThreshold int `mapstructure:"bundle_count_threshold"`
BundleByteThreshold int `mapstructure:"bundle_byte_threshold"`
BundleByteLimit int `mapstructure:"bundle_byte_limit"`
BufferMaxBytes int `mapstructure:"buffer_max_bytes"`
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@james-bebbington not for this PR, but bundle options are overkill. We already provide queuing and batching in the collector, and ideally the exporter should not do more than that.

@bogdandrutu bogdandrutu merged commit 8d1f6af into open-telemetry:master Nov 1, 2020
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
@bogdandrutu @tigrannajaryan
Update approvers, create triagers. (#1427)
db926fd 
* Update approvers, create triagers.

Signed-off-by: Bogdan Drutu <[email protected]>

* Update README.md

Co-authored-by: Tigran Najaryan <[email protected]>

Co-authored-by: Tigran Najaryan <[email protected]>
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
cleanup: drop the removed examples in gitignore (#1427)
1e4c832 
Signed-off-by: Guangwen Feng <[email protected]>
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@luke6Lh43
Remove db.name attribute from Redis instrumentation (#1427)
5f85a5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrannajaryan tigrannajaryan tigrannajaryan left review comments

@nilebox nilebox nilebox approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

Assignees

@nilebox nilebox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@james-bebbington @bogdandrutu @tigrannajaryan @nilebox