[Receiver/redisreceiver] Support redis.cpu.time with more label values for Redis versions >= 6.0 #14943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singku
force-pushed
the
main
branch
2 times, most recently
from
237663a to
b73ddea
Compare
dmitryax
reviewed
Oct 13, 2022
dmitryax
reviewed
Oct 18, 2022
dmitryax
reviewed
Oct 18, 2022
dmitryax
approved these changes
Oct 18, 2022
dmitryax
reviewed
Oct 18, 2022
|
CI seems to be failing. |
Add more state values to redis.cpu.time metrics to support sys_main_thread and user_main_thread cpu usage time.
|
Re-synced with head and CI is passing |
|
@jpkrohling FYI |
|
Any update? |
|
Gental ping @jpkrohling @codeboten @dmitryax |
|
last ping |
codeboten
approved these changes
Nov 15, 2022
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2022
…s for Redis versions >= 6.0 (open-telemetry#14943) Update Redis Receiver to Support CPU Metrics After 6.0 Add more state values to redis.cpu.time metrics to support sys_main_thread and user_main_thread cpu usage time.
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…s for Redis versions >= 6.0 (open-telemetry#14943) Update Redis Receiver to Support CPU Metrics After 6.0 Add more state values to redis.cpu.time metrics to support sys_main_thread and user_main_thread cpu usage time.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Redis with version >= 6.0 introduced two more cpu usage time items:
Link to tracking Issue:
Testing:
Existing test.
Documentation: