Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade otel collector core, fix changes after no nil Status #1757

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

bogdandrutu
Copy link
Member

Important changes only in Honeycomb exporter, will wait for their review.

@bogdandrutu
Copy link
Member Author

/cc @paulosman @lizthegrey @MikeGoldsmith the previous status logic was not confirming with specs and proto.

Please check the change, if this is not good and a quick fix is possible I will do it.

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #1757 (ec721ff) into master (778a07b) will increase coverage by 0.02%.
The diff coverage is 88.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1757      +/-   ##
==========================================
+ Coverage   89.85%   89.88%   +0.02%     
==========================================
  Files         376      376              
  Lines       18205    18185      -20     
==========================================
- Hits        16358    16345      -13     
+ Misses       1386     1381       -5     
+ Partials      461      459       -2     
Flag Coverage Δ
integration 69.77% <ø> (ø)
unit 88.58% <88.46%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/azuremonitorexporter/trace_to_envelope.go 98.39% <ø> (-0.02%) ⬇️
exporter/sentryexporter/sentry_exporter.go 92.36% <ø> (-0.11%) ⬇️
...eiver/awsxrayreceiver/internal/translator/cause.go 100.00% <ø> (ø)
.../awsxrayreceiver/internal/translator/translator.go 91.22% <ø> (-0.08%) ⬇️
exporter/datadogexporter/translate_traces.go 82.14% <71.42%> (ø)
...cloudlogserviceexporter/tracedata_to_logservice.go 100.00% <100.00%> (ø)
exporter/awsxrayexporter/translator/cause.go 96.85% <100.00%> (ø)
exporter/awsxrayexporter/translator/http.go 92.25% <100.00%> (ø)
...sticexporter/internal/translator/elastic/traces.go 93.91% <100.00%> (-0.04%) ⬇️
exporter/honeycombexporter/translator.go 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 778a07b...ec721ff. Read the comment docs.

@bogdandrutu
Copy link
Member Author

@bogdandrutu
Copy link
Member Author

Last ping @paulosman @lizthegrey @MikeGoldsmith

@paulosman
Copy link
Member

Looks fine to me. 👍

Important changes only in Honeycomb exporter, will wait for their review.

Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu bogdandrutu merged commit 4736695 into open-telemetry:master Dec 7, 2020
@bogdandrutu bogdandrutu deleted the spanstatusnil branch December 7, 2020 16:45
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants