-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade otel collector core, fix changes after no nil Status #1757
Conversation
/cc @paulosman @lizthegrey @MikeGoldsmith the previous status logic was not confirming with specs and proto. Please check the change, if this is not good and a quick fix is possible I will do it. |
Codecov Report
@@ Coverage Diff @@
## master #1757 +/- ##
==========================================
+ Coverage 89.85% 89.88% +0.02%
==========================================
Files 376 376
Lines 18205 18185 -20
==========================================
- Hits 16358 16345 -13
+ Misses 1386 1381 -5
+ Partials 461 459 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Last ping @paulosman @lizthegrey @MikeGoldsmith |
Looks fine to me. 👍 |
Important changes only in Honeycomb exporter, will wait for their review. Signed-off-by: Bogdan Drutu <[email protected]>
81db58f
to
ec721ff
Compare
Zipkin appears to need more memory and randomly fails sometimes, e.g.: https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-collector/3370/workflows/73f553df-16ba-40f4-aa04-8f01968b2728/jobs/34445
Co-authored-by: Tyler Yahn <[email protected]>
Important changes only in Honeycomb exporter, will wait for their review.