Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/awscloudwatchlogs] Flush logs on the exporter shutdown #18518

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Feb 13, 2023

The exporter implements the exporter.Traces interface but the implementation is not being used, exporterhelper.NewLogsExporter is applied instead. This change removes the implementation and moves the methods to NewLogsExporter options. This enables the Shutdown method which is currently ignored

@dmitryax dmitryax requested review from a team and atoulme February 13, 2023 02:30
@github-actions github-actions bot added the exporter/awscloudwatchlogs awscloudwatchlogs exporter label Feb 13, 2023
The exporter implements the `exporter.Traces` interface but the implementation is not being used, `exporterhelper.NewLogsExporter` is applied instead. This change removes the implementation and moves the methods to `NewLogsExporter` options. This enables the Shutdown methods which is currently ignored
@dmitryax dmitryax force-pushed the cwlogs-exporter-fix-shutdown branch from 849474f to 942fc1d Compare February 13, 2023 02:32
@runforesight
Copy link

runforesight bot commented Feb 13, 2023

Foresight Summary

    
Major Impacts

build-and-test-windows duration(11 seconds) has decreased 40 minutes 38 seconds compared to main branch avg(40 minutes 49 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 11 seconds (40 minutes 38 seconds less than main branch avg.) and finished at 13th Feb, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  check-links workflow has finished in 49 seconds (1 minute 41 seconds less than main branch avg.) and finished at 13th Feb, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 1 minute 15 seconds (1 minute 42 seconds less than main branch avg.) and finished at 13th Feb, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  changelog workflow has finished in 2 minutes 21 seconds (1 minute 22 seconds less than main branch avg.) and finished at 13th Feb, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 55 seconds (4 minutes 58 seconds less than main branch avg.) and finished at 13th Feb, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  build-and-test workflow has finished in 40 minutes 17 seconds (18 minutes 57 seconds less than main branch avg.) and finished at 13th Feb, 2023.


Job Failed Steps Tests
unittest-matrix (1.18, internal) -     🔗  ✅ 561  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) -     🔗  ✅ 537  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, internal) -     🔗  ✅ 561  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, extension) -     🔗  ✅ 537  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics -     🔗  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) -     🔗  ✅ 1479  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces -     🔗  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) -     🔗  ✅ 1479  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) -     🔗  ✅ 2574  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) -     🔗  ✅ 2574  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) -     🔗  ✅ 2452  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) -     🔗  ✅ 2452  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) -     🔗  ✅ 1959  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) -     🔗  ✅ 4684  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) -     🔗  ✅ 4684  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) -     🔗  ✅ 1959  ❌ 0  ⏭ 0    🔗 See Details
integration-tests -     🔗  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
checks -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
unittest (1.18) -     🔗  N/A See Details
lint -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  e2e-tests workflow has finished in 10 minutes 56 seconds (7 minutes 29 seconds less than main branch avg.) and finished at 13th Feb, 2023.


Job Failed Steps Tests
kubernetes-test -     🔗  N/A See Details

❌  load-tests workflow has finished in 5 minutes 51 seconds (10 minutes 50 seconds less than main branch avg.) and finished at 13th Feb, 2023. 1 job failed. There are 2 test failures.


Job Failed Steps Tests
loadtest (TestBallastMemory|TestLog10kDPS) Loadtest     🔗  ✅ 17  ❌ 2  ⏭ 0    🔗 See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@dmitryax dmitryax changed the title [exporter/awscloudwatch] Flush logs on the exporter shutdown [exporter/awscloudwatchlogs] Flush logs on the exporter shutdown Feb 13, 2023
@dmitryax dmitryax merged commit 6c0169a into open-telemetry:main Feb 13, 2023
@dmitryax dmitryax deleted the cwlogs-exporter-fix-shutdown branch February 13, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/awscloudwatchlogs awscloudwatchlogs exporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants