Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector/count] Add OTTL conditions to count connector #18687

Merged
merged 3 commits into from
Feb 20, 2023

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Feb 15, 2023

This is a major overhaul of the connector to add OTTL conditions.

Notably, this adds support for all OTTL contexts, which means we can now count span events and metrics, in addition to spans, data points, and logs.

Each of the five contexts is a top level config option. Multiple metrics can be defined for each context. Each metric may have zero or more conditionals applied.

@github-actions github-actions bot requested a review from jpkrohling February 15, 2023 19:47
@djaglowski djaglowski force-pushed the connector-count-if branch 2 times, most recently from ff99497 to 055e048 Compare February 15, 2023 19:52
@runforesight
Copy link

runforesight bot commented Feb 15, 2023

Foresight Summary

    
Major Impacts

build-and-test-windows duration(4 seconds) has decreased 42 minutes 9 seconds compared to main branch avg(42 minutes 13 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 4 seconds (42 minutes 9 seconds less than main branch avg.) and finished at 20th Feb, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 2 minutes 22 seconds (40 seconds less than main branch avg.) and finished at 20th Feb, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  check-links workflow has finished in 3 minutes 3 seconds and finished at 20th Feb, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  changelog workflow has finished in 3 minutes 8 seconds and finished at 20th Feb, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  load-tests workflow has finished in 15 minutes 33 seconds and finished at 20th Feb, 2023.


Job Failed Steps Tests
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 18  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 14 minutes 41 seconds (⚠️ 5 minutes 49 seconds more than main branch avg.) and finished at 20th Feb, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

❌  build-and-test workflow has finished in 44 minutes 9 seconds (23 minutes 4 seconds less than main branch avg.) and finished at 20th Feb, 2023. 2 jobs failed.


Job Failed Steps Tests
correctness-metrics -     🔗  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces -     🔗  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) -     🔗  ✅ 537  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, internal) -     🔗  ✅ 561  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, internal) -     🔗  ✅ 561  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, extension) -     🔗  ✅ 537  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) -     🔗  ✅ 1509  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, processor) -     🔗  ✅ 1509  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) -     🔗  ✅ 2575  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, receiver-0) -     🔗  ✅ 2575  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, exporter) -     🔗  ✅ 2455  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) -     🔗  ✅ 1928  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) -     🔗  ✅ 4772  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) -     🔗  ✅ 2455  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, receiver-1) -     🔗  ✅ 1928  ❌ 0  ⏭ 0    🔗 See Details
integration-tests -     🔗  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, other) -     🔗  ✅ 4772  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) Lint     🔗  N/A See Details
build-examples -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
checks -     🔗  N/A See Details
unittest (1.20) -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
lint Interpret result     🔗  N/A See Details
cross-compile -     🔗  N/A See Details
build-package -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  e2e-tests workflow has finished in 11 minutes 32 seconds (4 minutes 12 seconds less than main branch avg.) and finished at 20th Feb, 2023.


Job Failed Steps Tests
kubernetes-test (v1.26.0) -     🔗  N/A See Details
kubernetes-test (v1.25.3) -     🔗  N/A See Details
kubernetes-test (v1.24.7) -     🔗  N/A See Details
kubernetes-test (v1.23.13) -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@djaglowski djaglowski force-pushed the connector-count-if branch 2 times, most recently from 40004ea to e9de433 Compare February 16, 2023 15:00
@djaglowski djaglowski force-pushed the connector-count-if branch 2 times, most recently from 285b58f to ec9f178 Compare February 16, 2023 16:47
@djaglowski djaglowski marked this pull request as ready for review February 16, 2023 17:40
@djaglowski djaglowski requested a review from a team February 16, 2023 17:40
@djaglowski
Copy link
Member Author

@TylerHelmuth, would you mind giving the ottl related parts a look over?

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OTTL stuff looks correct. Sorry for the annoying verbosity. When I can find time I'll try to simplify some of the boilerplate into internal/filter

connector/countconnector/README.md Outdated Show resolved Hide resolved
connector/countconnector/README.md Outdated Show resolved Hide resolved
connector/countconnector/README.md Outdated Show resolved Hide resolved
connector/countconnector/ottl.go Show resolved Hide resolved
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OTTL stuff looks good to me

@djaglowski djaglowski requested a review from kovrus February 20, 2023 15:04
connector/countconnector/factory.go Show resolved Hide resolved
@djaglowski djaglowski merged commit ba5815c into open-telemetry:main Feb 20, 2023
@djaglowski djaglowski deleted the connector-count-if branch February 20, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants