Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/awsecscontainermetricsreceiver] Fix possible sigsegv in shutdown #18736

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

bryan-aguilar
Copy link
Contributor

Description: Fix possible sigsev error that could occur during shutdown if component was not correctly initialized.

Link to tracking Issue: Reported in ADOT downstream repository aws-observability/aws-otel-collector#982 (comment)

@runforesight
Copy link

runforesight bot commented Feb 16, 2023

Foresight Summary

    
Major Impacts

TestMySqlIntegration ❌ failed 1 times in 2 runs (50% fail rate).
TestMySqlIntegration/Running_mysql_version_8.0 ❌ failed 1 times in 2 runs (50% fail rate).
build-and-test-windows duration(3 seconds) has decreased 42 minutes 10 seconds compared to main branch avg(42 minutes 13 seconds).
View More Details

✅  check-links workflow has finished in 45 seconds (1 minute 50 seconds less than main branch avg.) and finished at 17th Feb, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 1 minute 19 seconds (1 minute 48 seconds less than main branch avg.) and finished at 17th Feb, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 5 minutes 22 seconds (3 minutes 24 seconds less than main branch avg.) and finished at 17th Feb, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 15 minutes 53 seconds and finished at 17th Feb, 2023.


Job Failed Steps Tests
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 18  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

✅  e2e-tests workflow has finished in 15 minutes 37 seconds and finished at 17th Feb, 2023.


Job Failed Steps Tests
kubernetes-test -     🔗  N/A See Details

⭕  build-and-test-windows workflow has finished in 3 seconds (42 minutes 10 seconds less than main branch avg.) and finished at 20th Feb, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  changelog workflow has finished in 4 minutes 55 seconds (⚠️ 2 minutes 20 seconds more than main branch avg.) and finished at 20th Feb, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  build-and-test workflow has finished in 6 minutes 53 seconds (1 hour 0 minutes 20 seconds less than main branch avg.) and finished at 20th Feb, 2023.


Job Failed Steps Tests
build-package (deb) -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

Copy link
Member

@Aneurysm9 Aneurysm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry.

@bryan-aguilar
Copy link
Contributor Author

Please add a changelog entry.

Doh! My bad. Coming right up

@bryan-aguilar bryan-aguilar changed the title [receiver/awsecscontainermetricsreceiver] Fix possible sigsev in shutdown [receiver/awsecscontainermetricsreceiver] Fix possible sigsegv in shutdown Feb 17, 2023
@Aneurysm9 Aneurysm9 added the ready to merge Code review completed; ready to merge by maintainers label Feb 20, 2023
@codeboten codeboten merged commit 31d48a5 into open-telemetry:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/awsecscontainermetrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants