Migrate attributesprocessor from Collector core to Collector contrib #4665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default retry settings are far off from the Prometheus Server's behavior. Retry more aggressively to avoid excessive in-memory buffering. Also fixes open-telemetry/prometheus-interoperability-spec#54 because the test times out before the retry is sent.
…nalRep usage (#3398) Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
* zipkinv1: move to translator and encoders interfaces * review feedback
…otlprecv (#3386) Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
…#3387) Signed-off-by: Bogdan Drutu <[email protected]>
Bumps [go.uber.org/atomic](https://github.com/uber-go/atomic) from 1.7.0 to 1.8.0. - [Release notes](https://github.com/uber-go/atomic/releases) - [Changelog](https://github.com/uber-go/atomic/blob/master/CHANGELOG.md) - [Commits](uber-go/atomic@v1.7.0...v1.8.0) --- updated-dependencies: - dependency-name: go.uber.org/atomic dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…erent than grpc (#3422) Signed-off-by: Bogdan Drutu <[email protected]>
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.10.0 to 1.11.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/master/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.10.0...v1.11.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…3406) Signed-off-by: Bogdan Drutu <[email protected]>
* Edited grammar of pdata doc.go * Added missing word * Fixed typos in pdata/common.go * Added missing String method docs This fix makes the pdata folder consistent in documenting the String methods. * Fixed spacing in doc example * Fixed spacing issues in multiple examples This issue was causing many example snippets to show up incorrectly on the godoc * Fixed spacing issue on Range example * Fixed spacing in At example * Fixed more spacing errors in examples * Fixed error in ResourceMetrics header describing InstrumentationLibraryMetrics * Fixed another header referencing wrong method * Added documentation for pdata.Resource * Updated outdated links to Span OTLP definition * Cleaned up wording in SpanStatus doc * Fixed more spacing errors in examples * Fixed typos in type docs * Cleaned up formatting in consumererror * Cleaned up consumerhelper doc typos * Updated docs in consumertest - Fixed wrong description of NewErr - Added doc for Capabilities method * Update CHANGELOG.md * Fixed formatting errors in cmd/pdatagen Changing here will ensure that the changes to consumer/pdata/generated_* files will persist after running `go run cmd/pdatagen/main.go`. * Removed unused imports * Update CHANGELOG.md * Fixed generated code lint failures * Revert changes in pdatagen and pdata/generated * Update NewErr docstring For func defined in consumer/consumertest/err.go Co-authored-by: Tigran Najaryan <[email protected]> * Updated docstring for TraceState Renamed "message" to "string" Co-authored-by: Tigran Najaryan <[email protected]>
Updates #3104 Signed-off-by: Bogdan Drutu <[email protected]>
Updates #3104 Signed-off-by: Bogdan Drutu [email protected]
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
…ce (#3437) Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
… cannot be used (#3421) Signed-off-by: Bogdan Drutu <[email protected]>
…released (#3434) Signed-off-by: Bogdan Drutu <[email protected]>
* zipkinv2: add encoders, decoders, marshalers Also update zipkin receiver to use them. * don't check returned value on error * review feedback Co-authored-by: Bogdan Drutu <[email protected]>
Go development practices favors returning concrete types over interfaces, so the users don't have to force cast the return value to the concrete type and the APIs self document the returned error type.
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
* disallow renaming metrics using the prometheus receiver * add TODO for removing the validation
* Create snyk-container-analysis.yml * Create snyk-container-analysis.yml * Renamed occurrences of Application to Collector - Changed references in function/method docs from 'application' to 'collector server' - Changed instance variable names from (app *Application) to (col *Collector) * Rename more instances of Application to Collector - renamed files in service/application* to service/collector* - replaced occurrences of app to col * Renamed references of service.Application to collector (or collector server) * Added change log entry stub * Added number of PR * Fixed merge conflicts * Update CHANGELOG.md * Renamed ColSettings to CollectorSettings * Fixed naming error * Delete snyk-container-analysis.yml * Moved change log entry unreleased section From v0.28.0-beta to unreleased (breaking change) * Deleted extra new line in change log * Renamed occurrences of Application to Collector - Changed references in function/method docs from 'application' to 'collector server' - Changed instance variable names from (app *Application) to (col *Collector) * Rename more instances of Application to Collector - renamed files in service/application* to service/collector* - replaced occurrences of app to col * Renamed references of service.Application to collector (or collector server) * Added number of PR * Fixed merge conflicts * Renamed ColSettings to CollectorSettings * Fixed naming error * Moved change log entry unreleased section From v0.28.0-beta to unreleased (breaking change) * Removed misplaced newline Co-authored-by: Karen Xu <[email protected]> Co-authored-by: Iris Song <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
* Bump github.com/jaegertracing/jaeger from 1.24.0 to 1.25.0 Bumps [github.com/jaegertracing/jaeger](https://github.com/jaegertracing/jaeger) from 1.24.0 to 1.25.0. - [Release notes](https://github.com/jaegertracing/jaeger/releases) - [Changelog](https://github.com/jaegertracing/jaeger/blob/master/CHANGELOG.md) - [Commits](jaegertracing/jaeger@v1.24.0...v1.25.0) --- updated-dependencies: - dependency-name: github.com/jaegertracing/jaeger dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Add logger parameter to Jaeger Agent HTTP server Signed-off-by: Juraci Paixão Kröhling <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Juraci Paixão Kröhling <[email protected]>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.39.0 to 1.39.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.39.0...v1.39.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/go-playground/validator/v10](https://github.com/go-playground/validator) from 10.8.0 to 10.9.0. - [Release notes](https://github.com/go-playground/validator/releases) - [Commits](go-playground/validator@v10.8.0...v10.9.0) --- updated-dependencies: - dependency-name: github.com/go-playground/validator/v10 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
…#3808) Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
This PR cuts out a few steps, including copying the map, calling IntfaceKeysToStrings, and merging the map with an empty map. Signed-off-by: Bogdan Drutu <[email protected]>
* update oc internal, prometheus exporters to use attributes * rename addAttributesToDoubleHistogramDataPoints * cleaned up TODOs, mentioned the code in the issue instead
Moving AttributeValueToString and AttributeMapToMap from `tracetranslator` to `pdata` for common use across signals. The original functions were left as wrappers to their `pdata` counterparts and marked as deprecated. **Link to tracking Issue:** First part of open-telemetry/opentelemetry-collector#3815 **Testing:** Moved existing tests to common_test
Updating `LabelsMap` to `Attributes` for hostmetrics receiver. **Link to tracking Issue:** Part of #3535
…ig (#3706) Signed-off-by: Bogdan Drutu <[email protected]>
alolita
added
release:required-for-ga
|
Hi @bogdandrutu @tigrannajaryan based on our discussion last week, we're starting to file PRs to move each core component to contrib. Please review and merge. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the attributesprocessor component from the Collector core repository to the Collector contrib repository.
This PR retains the commit history from core and includes plumbing fixes for go.mod, makefile, components.go.
Related issues include:
opentelemetry-collector/#3474
opentelemetry-collector/#3643