[receiver/mongodbatlas] fix attribute key on disk partition metrics #7747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstumpfx
force-pushed
the
mongodbatlas
branch
from
67960f0 to
57f3a6e
Compare
zenmoto
approved these changes
Feb 7, 2022
dmitryax
approved these changes
Feb 8, 2022
mstumpfx
force-pushed
the
mongodbatlas
branch
from
57f3a6e to
9eb56f9
Compare
bogdandrutu
reviewed
Feb 10, 2022
| @@ -579,15 +579,15 @@ metrics: | |||
| description: Disk partition space | |||
| extended_documentation: Aggregate of MongoDB Metrics DISK_PARTITION_SPACE_FREE, DISK_PARTITION_SPACE_USED | |||
| unit: By | |||
| attributes: [memory_state] | |||
| attributes: [disk_status] | |||
There was a problem hiding this comment.
Why do we need to repeat "disk"? "status" is not enough?
As example for host metrics we don't have "memory_state" and "cpu_state".
There was a problem hiding this comment.
Looks like all the attribute names in this scraper have prefixes like memory_, ticket_, cache_, disk_ etc.
I know that we aim to avoid such prefixes in other scrapers but cannot find any guidelines in the spec other than this:
Common attributes SHOULD be consistently named. This aids in discoverability and disambiguates similar attributes to metric names.
@bogdandrutu do you know if we have such guidelines somewhere? maybe I miss it.
mstumpfx
force-pushed
the
mongodbatlas
branch
from
9eb56f9 to
d417cac
Compare
mstumpfx
force-pushed
the
mongodbatlas
branch
2 times, most recently
from
4ca9776 to
3f62a78
Compare
codeboten
reviewed
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: These should have all been using the
disk_statuskey for the attributes, notmemory_state.