Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/datadog] Fix broken link and typo in README.md #9392

Conversation

Donnerbart
Copy link
Contributor

Description: Fix the link to the custom sampler example. Fix a typo.

Link to tracking Issue: #9391

Testing: Tested using the markdown preview in my IDE.

Documentation: Fixed the documentation, not the code itself.

@Donnerbart Donnerbart requested a review from a team April 21, 2022 09:28
@Donnerbart Donnerbart requested a review from mx-psi as a code owner April 21, 2022 09:28
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 21, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Donnerbart / name: Donnerbart (60a94ed)

@mx-psi mx-psi linked an issue Apr 21, 2022 that may be closed by this pull request
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 🙇

@mx-psi
Copy link
Member

mx-psi commented Apr 21, 2022

@Donnerbart for this to be mergeable you need to sign the CNCF CLA, could you do that? Thanks!

@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 21, 2022
@Donnerbart
Copy link
Contributor Author

@mx-psi I'm currently trying to figure out if I need to sign the corporate CLA (there might be more contributions to OTel coming long-term).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[exporter/datadog] Broken link in README.md
3 participants