Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm chart to deploy collector into Kubernetes #1490

Closed
pavolloffay opened this issue Aug 4, 2020 · 9 comments
Closed

Add helm chart to deploy collector into Kubernetes #1490

pavolloffay opened this issue Aug 4, 2020 · 9 comments
Labels
enhancement New feature or request
Milestone

Comments

@pavolloffay
Copy link
Member

Is your feature request related to a problem? Please describe.

Deploy opentelemetry-collector into Kubernetes and allow easy integrations with other helm chart based installers.

Describe the solution you'd like

OTEL collector helm chart.

Describe alternatives you've considered

Use the https://github.com/open-telemetry/opentelemetry-operator, however it is not convenient in pure helm environments.

Additional context

None.

@pavolloffay
Copy link
Member Author

We should decide whether it will be versioned in this repository or in a separate like the operator.

I can submit a PR.

@mikelorant
Copy link

I have implemented a Helm chart for opentelemetry-operator. I have also created a Helm chart that creates a resource for OpenTelelemetryCollector which is acted on by the operator.

https://github.com/fairfaxmedia/charts/tree/master/stable/opentelemetry-operator
https://github.com/fairfaxmedia/charts/tree/master/stable/opentelemetrycollector

This I feel is a better result than directly creating a chart for the collector itself.

@tigrannajaryan tigrannajaryan added this to the Backlog milestone Aug 12, 2020
@genebean
Copy link

I have written a helm chart for our internal deployment of the collector and would be happy to contribute it if desired.

@mikelorant
Copy link

@genebean Would it be worthwhile comparing what we have and seeing if we can combine them?

@genebean
Copy link

I'd be game for that. I think it could be fairly easy to make it so the chart would work standalone or as part of the operator. If that sounds practical to you, I will work up a PR for your repo.

@mikelorant
Copy link

Have a look at my approach and see if it suits you. I based it some very specific needs so it might not work well for others. I mostly wanted to be able to generate the collector config from layered values files. Didn't work as well as I hoped due to how Helm handles empty keys.

I allowed the operator to be able to define a collector config or be able to use another chart to put down the collector CRD. This I think worked quite well even though the operator still needs a lot more work to get to a mature status.

May I ask why you decided to use the collector directly rather than the operator?

@genebean
Copy link

Honestly... because I had no idea the operator was a thing. It didn't show up in any of the places I looked. Also, I don't actually see what the operator give me here as this is not a complicated deployment.

@genebean
Copy link

I will also take a more detailed look at the operator though and make sure that it isn't a better fit for us

@andrewhsu andrewhsu added enhancement New feature or request and removed feature request labels Jan 6, 2021
@flands
Copy link
Contributor

flands commented Feb 1, 2021

https://github.com/open-telemetry/opentelemetry-helm-charts exists now with a helm -- please open issues / contribute there

@flands flands closed this as completed Feb 1, 2021
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants