-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(batchprocessor): Add tracing support #11324
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11324 +/- ##
==========================================
- Coverage 92.14% 91.51% -0.63%
==========================================
Files 433 433
Lines 20396 23701 +3305
==========================================
+ Hits 18794 21691 +2897
- Misses 1238 1642 +404
- Partials 364 368 +4 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Bogdan Drutu <[email protected]>
…tor into jmacd/cb_re3
…tor into jmacd/cb_re3
…or into jmacd/cb_re3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @bogdandrutu, you had a lot of feedback on this PR. Have your changes been addressed?
Having a lot of feedback is it bad or good? Or why did you mentioned this?
Not yet, some of the answers to my comments I am unable to understand (most likely because of my IQ level, or other factors). I am still in the understanding mode, and I cannot approve something I don't understand the complexity. |
@evan-bradley What do you think? This is a simple PR to add tracing to a critical component, and I have tried to explain that this is only one of the steps involved in fixing #11308. |
@bogdandrutu please clarify. I can't guess at which parts of this PR and the overall #11308 are causing trouble. |
Disappointed. |
Description
The batch processor is frequently responsible for breaking trace context for data passing through the collector. This fixes the batch processor to either continue the trace context (if one parent) or to link the parent contexts. The motivation for this change goes beyond tracing. The same data structure is used in following PRs to address #11308, in which the
pendingItem
data structure will gain a channel so the export can inform the waiter about completion(s), in which theparentCtx.Done()
channel is used to avoid blocking when the caller has already returned.Link to tracking issue
Part of #11308
Testing
Two new tests for single-parent and multi-parent trace data.
Documentation
Added.