Fix OTLP waitForReady, not set from config #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
requested review from
dmitryax,
flands,
james-bebbington,
owais,
pjanotti,
rghetia and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1254 +/- ##
==========================================
- Coverage 88.54% 88.50% -0.04%
==========================================
Files 207 207
Lines 14945 14948 +3
==========================================
- Hits 13233 13230 -3
- Misses 1283 1286 +3
- Partials 429 432 +3
Continue to review full report at Codecov.
|
nilebox
approved these changes
Jul 6, 2020
| gs.logExporter = otlplogcol.NewLogServiceClient(gs.grpcClientConn) | ||
| gs.metadata = metadata.New(config.GRPCClientSettings.Headers) | ||
|
|
||
| gs := &grpcSender{ |
There was a problem hiding this comment.
nit: You don't need the gs variable anymore, can just return inline.
There was a problem hiding this comment.
I had that before, but I kind of don't like that the error nil is most invisible.
There was a problem hiding this comment.
Also a decent compiler should inline that so not worried that much
james-bebbington
approved these changes
Jul 7, 2020
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
Signed-off-by: Bogdan Drutu <[email protected]>
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Update Span API event methods Remove the context argument from the event methods. It is unused and can be added back in as a passed option if needed in the future. Update AddEvent to accept a required name and a set of options. These options are the new EventOption type that can be used to configure a SpanConfig Timestamp and Attributes. Remove the AddEventWithTimestamp method as it is redundant to calling AddEvent with a WithTimestamp option. Update RecordError to also accept the EventOptions. * Add changes to CHANGELOG * Add LifeCycleOption Use the LifeCycleOption to encapsulate the options passed to a span for life cycle events.
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.