Add device filter for disk scraper #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
flands,
owais,
pjanotti,
rghetia and
tigrannajaryan
as code owners
james-bebbington
force-pushed
the
disk-device-filter
branch
3 times, most recently
from
e330a12 to
d99bba0
Compare
Codecov Report
@@ Coverage Diff @@
## master #1378 +/- ##
==========================================
- Coverage 90.32% 90.32% -0.01%
==========================================
Files 218 218
Lines 15292 15311 +19
==========================================
+ Hits 13812 13829 +17
- Misses 1071 1072 +1
- Partials 409 410 +1
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Jul 17, 2020
bogdandrutu
reviewed
Jul 17, 2020
receiver/hostmetricsreceiver/internal/scraper/diskscraper/disk_scraper_others.go
Outdated
Show resolved
Hide resolved
james-bebbington
force-pushed
the
disk-device-filter
branch
from
d99bba0 to
0fc7655
Compare
bogdandrutu
reviewed
Jul 17, 2020
receiver/hostmetricsreceiver/internal/scraper/diskscraper/disk_scraper_others.go
Outdated
Show resolved
Hide resolved
james-bebbington
force-pushed
the
disk-device-filter
branch
from
0fc7655 to
50bf3a3
Compare
james-bebbington
force-pushed
the
disk-device-filter
branch
from
50bf3a3 to
554d196
Compare
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Push->basic * Repackage * Rename away from push * Make exporter optional; export from a separate goroutine * Move pull_test into controller_test * Precommit pass * New OTLP/Prom example * Precommit * Fix the example * Shorten the example * Test starting controller w/o exporter * Test export timeout * Remove ancient example & lint * go.mod revert & tidy * Comments * Tidy a diff * Tidy a diff * Move export kind selector in the new example * Split this test into its original parts * Reduce diff size * Changelog * Remove extra Add/Done pair * Remove unused stopCh param; document the Stop behavior * Typo * Use ctx * Missed v0.15 * Apply PR feedback * Precommit pass * 0.14 -> 0.15 in new file * Remove diff chunk markers * Fix OTLP example * Upstream * dashpole comments * aneurysm9 feedback * Tidy go.sum
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.