Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DB conventions to latest and add exception conventions #1452

Merged

Conversation

anuraaga
Copy link
Contributor

Updates to latest semantic conventions.

I also made the span generator a copy of the examples on the semantic conventions document for easier maintenance, hope this makes sense.

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #1452 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1452   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files         234      234           
  Lines       16472    16476    +4     
=======================================
+ Hits        14962    14966    +4     
  Misses       1082     1082           
  Partials      428      428           
Impacted Files Coverage Δ
internal/goldendataset/span_generator.go 98.88% <100.00%> (+0.01%) ⬆️
receiver/otlpreceiver/otlp.go 91.66% <0.00%> (-2.78%) ⬇️
translator/internaldata/resource_to_oc.go 86.04% <0.00%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39521ed...47b09ae. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit 9cbf43e into open-telemetry:master Jul 28, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* Move Span Event to API

* Add changes to CHANGELOG
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2 to 3.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v2...v3)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants