If filterprocessor filters all data, stop further processing #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anniefu
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## master #1500 +/- ##
==========================================
+ Coverage 90.98% 91.02% +0.03%
==========================================
Files 239 239
Lines 16744 16750 +6
==========================================
+ Hits 15235 15247 +12
+ Misses 1080 1077 -3
+ Partials 429 426 -3
Continue to review full report at Codecov.
|
|
@bogdandrutu, @james-bebbington please review when you get a chance, thanks! |
james-bebbington
approved these changes
Aug 13, 2020
|
@bogdandrutu could you take a look when you get a minute? Thanks! |
Oh, cool, I was not aware of |
bogdandrutu
approved these changes
Aug 13, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…n-telemetry#1501) * Reverse order of attribute precedence when merging two Resources This reflects a change in the specification itself. open-telemetry/opentelemetry-specification#1345 * Resolves open-telemetry#1500 Co-authored-by: Tyler Yahn <[email protected]>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
* Add syslog receiver * Update components.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a sentinel error to
processhelperpackage that can be returned by other processors to indicate that the incoming batch of metrics data has been determined to be irrelevant and should be skipped for any further processing. If skipped,processhelperwill nullify the sentinel error and returnnil.Have the filterprocessor return the sentinel error if all metrics are filtered out by the filters. This prevents any further unnecessary processing and exporting of the empty metrics data.
Link to tracking Issue: #1491
Testing: Unit tests
Documentation: N/A, no user-facing changes to fix big (though I did fix some typos in existing doc).